chore: fix two comment typos#22524
Merged
Merged
Conversation
- datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs L737: scalarized_intern_remaining doc said "preform" -> "perform" - datafusion/core/tests/dataframe/mod.rs L843: comment said "functionally dependant" -> "functionally dependent" Comment-only.
github-actions
Bot
added
core
ariel-miculas
approved these changes
May 26, 2026
2010YOUY01
approved these changes
May 27, 2026
Contributor
2010YOUY01
left a comment
2010YOUY01
left a comment
There was a problem hiding this comment.
Thank you!
I'll plan to merge it after the CI passes.
Contributor
Author
|
Thanks @2010YOUY01 for taking the two comment typo fixes in the group_values code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:737-scalarized_intern_remainingdoc said "preform" → "perform"datafusion/core/tests/dataframe/mod.rs:843,895,943- three nearly-identical test comments said "functionally dependant" → "functionally dependent"Comment-only.